Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-20984: Move placement of payment processor field #10787

Merged
merged 1 commit into from
Jul 31, 2017

Conversation

monishdeb
Copy link
Member

@monishdeb monishdeb commented Jul 30, 2017

Overview

Currently, on 'Submit Credit Card Contribution' or any live payment form there is a visual disconnect between payment processor field and its billing block. To resolve that move the processor field just above the billing block section kind of placement we already have in online contribution page registration form.

Before

image

After

image

Technical Details

Above screenshots depict the UI change in 'Submit Credit Card Contribution' form. Similarly, the changes are made in following forms:

  1. Submit Credit Card Event Registration
  2. Submit Credit Card Membership
  3. Submit Credit Card payment (additional payment)
  4. Submit Credit Card Membership Renewal

@pradpnayak
Copy link
Contributor

Works fine

On Submit Credit Card Contribution

Before
beforecontributioncc

After
aftercontributioncc

On Submit Credit Card Membership

Before
beforemembershipcc

After
aftermembershipcc

On Submit Credit Card Participant

Before
beforeparticipantcc

After
afterparticipantcc

On Submit Credit Card Payment

Before
beforepaymentcc

After
afterpaymentcc

@eileenmcnaughton
Copy link
Contributor

I agree this placement looks better. Thanks for all the screenshots. Code is just moving some rows around

@eileenmcnaughton eileenmcnaughton merged commit e53b68a into civicrm:master Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants