CRM-20610 add a form for editing payment details #10774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a link to the left of the payment listing for editing payments. Provided the payments do not have an attached payment processor it is possible to edit the check number, or card_type_id and pan_truncation, along with the trxn_date
I have added comments to some things I'd really like to see tidied up (but could not reasonably extend the scope here to include)
|
@eileenmcnaughton after merging this will submit a separate PR to fix these:
On top of that, do you want to add any more financial_trxn fields to like |
|
How would it cause regression - this doesn't touch contribution edit form at all? I've just started looking at the changes to that form |
|
Oh, just realised - I also changed the pan_truncation to be optional (as people won't always know) |
|
Tested the above changes. Works fine 👍 |
|
Yep - the other changes you mention are part of your total goal - but this is useful in & of itself |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@monishdeb I started looking at #10729 - but there appear to be a few changes in there that I need to work through. This PR here represents the portion of that PR that I have reviewed, tested & approved.
Can you please check this still looks good to you & merge it.
Note the change included in this is the addition of the payment form, available from contribution tab when expanded. I have not reviewed the addition of this to the contribution edit form yet, or any other changes to that form as yet. It will require a rebase of the other PR but I think it won't be too bad. I did alter the query change in getPaymentInfo a little, to only get one extra field