Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-19575 - CRM_Utils_System_Joomla - Fix warning. Define JDEBUG #10715

Merged
merged 1 commit into from
Jul 22, 2017

Conversation

totten
Copy link
Member

@totten totten commented Jul 21, 2017

Background

When running cv en <extname> on Joomla, there are repeated warnings, "Use
of undefined constant JDEBUG", and each includes a backtrace. This is hard
to read.

The bug appears to affect backend scripts; it's discussed with a solution in:

joomla/joomla-cms#11512 (comment)

Before

CRM_Utils_System_Joomla::loadBootStrap() loads various config files.
However, these may or may not set JDEBUG.

After

CRM_Utils_System_Joomla::loadBootStrap() defensively sets JDEBUG if no
other part of the bootstrap has done so.



Background
==========

When running `cv en <extname>` on Joomla, there are repeated warnings, "Use
of undefined constant JDEBUG", and each includes a backtrace.  This is hard
to read.

The bug appears to affect backend scripts; it's discussed with a solution in:

joomla/joomla-cms#11512 (comment)

Before
======

`CRM_Utils_System_Joomla::loadBootStrap()` loads various config files.
However, these may or may not set `JDEBUG`.

After
=====

`CRM_Utils_System_Joomla::loadBootStrap()` defensively sets `JDEBUG` if no
other part of the bootstrap has done so.
@totten
Copy link
Member Author

totten commented Jul 21, 2017

Pinging Joomla experts for review: any 👍 or 👎 from @thoni56, @lcdservices, @brucew2013 ?

@totten totten changed the title CRM-20932 - CRM_Utils_System_Joomla - Fix warning. Define JDEBUG CRM-19575 - CRM_Utils_System_Joomla - Fix warning. Define JDEBUG Jul 21, 2017
@lcdservices
Copy link
Contributor

just ran into this with an upgrade. confirming that this fixed the issue.

@totten
Copy link
Member Author

totten commented Jul 21, 2017

Thanks @lcdservices . Glad it works for you too. I'm flagging merge ready.

I'll wait a day to merge in case any watchers report problems.

@totten totten added the merge ready PR will be merged after a few days if there are no objections label Jul 21, 2017
@totten totten merged commit 7d88fcc into civicrm:master Jul 22, 2017
@totten totten deleted the master-jdebug branch July 22, 2017 18:04
@brucew2013
Copy link

Perhaps there is something to glean from in this Joomla support thread https://forum.joomla.org/viewtopic.php?t=902641

Also, some report missing files after Joomla update(s).

@thoni56
Copy link

thoni56 commented Jul 26, 2017

@brucew2013, what exactly do you mean is the relevant part of that thread about a failed update of Joomla?

@brucew2013
Copy link

brucew2013 commented Jul 26, 2017

There are several references that Joomla updates may be the culprit. There isn't any thing specific codewise but just folks experiencing this after certain updates. Again, perhaps this is irrelevant but the only reference I can find regarding Joomla.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants