CRM-20848: Upgrade to 4.7.19 sets price_field to inactive if default Financial Types are disabled

[monishdeb]

• CRM-20848: Upgrade to 4.7.19 sets price_field to inactive if default Financial Types are disabled

[monishdeb]

@seamuslee001 @eileenmcnaughton there's a scenario when a FT is disabled and is used in non-quick-config price-sets (like contribution_default_amount that is use to record back-office contribution), got inactive. As per the upgrade handled for CRM-19517 - https://github.com/civicrm/civicrm-core/pull/9276/files#diff-d93eef22beca53aeaf6930348aa469b5R11 , that disables all the price-set that use disabled FT.

These lead to an issue reported in https://issues.civicrm.org/jira/browse/CRM-20848. So will it be ok to bypass this rule for non-quick-config by letting them active despite having disabled FT, as per the current patch? Otherwise, it's not possible for some non-quick-config price sets to change their FT from UI.

[eileenmcnaughton]

@seamuslee001 This is an update to a change you worked on. It makes sense to me & I'm OK with it if you are. In terms of risk it is only activating price sets so v low

[seamuslee001]

Agreed and makes sense given this is what we encountered. Tests have passed which is a good sign.