CRM-20875 - Fix membership import to avoid notice error to be thrown #10664
Conversation
jitendrapurohit
commented
Jul 14, 2017
•
jitendrapurohit
commented
- CRM-20875: Import of membership custom data throws notice errors.
|
This looks sensible to me @eileenmcnaughton does it make sense to you? @jitendrapurohit is there anyway to get a test added to this? |
| @@ -279,7 +279,8 @@ public function import($onDuplicate, &$values) { | |||
| $session = CRM_Core_Session::singleton(); | |||
| $dateType = $session->get('dateTypes'); | |||
| $formatted = array(); | |||
| $customFields = CRM_Core_BAO_CustomField::getFields(CRM_Utils_Array::value('contact_type', $params)); | |||
| $customDataType = !empty($params['contact_type']) ? $params['contact_type'] : 'Membership'; | |||
| $customFields = CRM_Core_BAO_CustomField::getFields($customDataType); | |||
There was a problem hiding this comment.
onto single line change by
$customFields = CRM_Core_BAO_CustomField::getFields(CRM_Utils_Array::value('contact_type', $params, 'Membership'));
If $customDataType is not used below
|
I think in case of notice error or any user warning we can avoid adding UT unless it's affecting the workflow. Still it's always good to have test coverage wherever it's possible |
|
I agree that @monishdeb change to one line is nicer - but I think it is minimal enough I don't think this needs to be held on that. Re unit tests - once again I agree that they are preferable. However, I also acknowledge that this is a very small change & I'm going to merge it |
|
@monishdeb Apologies for not pushing the one-liner for the change. I thought of testing it on php7 and then update, but somehow missed. |
