CRM-20833: Change APIv4 Entity Namespace Again #10632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Although it was just updated we decided to change the
API\V4namespace as it's longer than necessary and we would be better sticking to theVendor\Packageconvention, in this caseCivi\Api4.Before
The APIv4 entity namespace pointed to
Civi\API\V4\EntityAfter
The APIv4 entity namespace points to
Civi\Api4\EntityNotes
This PR should not be merged before civicrm/org.civicrm.api4#69 is merged.