Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Add unit test towards CRM-20759 #10594

Merged
merged 3 commits into from
Jul 4, 2017
Merged

[NFC] Add unit test towards CRM-20759 #10594

merged 3 commits into from
Jul 4, 2017

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jul 2, 2017 •
edited by civicrm-builder
Loading

@monishdeb this is the commit that starts to add in the unit testing & also does a little more tidying.

@eileenmcnaughton
Copy link
Contributor Author

test this please

monishdeb
monishdeb approved these changes Jul 4, 2017
View reviewed changes
Copy link
Member

@monishdeb monishdeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working fine

@monishdeb monishdeb merged commit 1f356cc into civicrm:master Jul 4, 2017
@eileenmcnaughton
Copy link
Contributor Author

thanks @monishdeb

@eileenmcnaughton eileenmcnaughton deleted the extract2 branch July 4, 2017 21:14
eileenmcnaughton added a commit to eileenmcnaughton/civicrm-core that referenced this pull request Jul 19, 2017
@eileenmcnaughton
CRM-20759 enable Primary as an import location type.
e25ed79 
Upstream Prs
civicrm#10594
civicrm#10565

Note the PRs that were merged prior to 4.7.21 being released
I have already included in the upgrade commit

Primary goes to the default location type if the contact has no primary, or overwrites primary,
in keeping with profile behaviour

Bug: T169025

Change-Id: I16530b770ee0fe1fd00db87eca47ba6a5f8d7543
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monishdeb monishdeb monishdeb approved these changes

Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @monishdeb @civicrm-builder