CRM-20756 - Add Angular ui.bootstrap library
#10545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the library [ui.bootstrap](https://angular-ui.github.io/bootstrap/), which makes it easier to include the functional elements of Bootstrap in AngularJS pages. In the past, adding this was problematic, but now the situation has improved: 1. civicrm-core has upgraded to AngularJS 1.5. (In the past, civicrm-core used AngularJS 1.3, which was incompatible.) 2. civicrm-core allows optional AngularJS modules. (In the past, all modules were loaded unconditionally, which could result in loading new/unnecessary code for legacy users. Now, you can opt-out of this behavior with `basePages=>array()`.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the library ui.bootstrap, which makes it easier to include the functional elements of Bootstrap in AngularJS pages.
In the past, adding this was problematic, but now the situation has improved:
civicrm-core has upgraded to AngularJS 1.5. (In the past, civicrm-core
used AngularJS 1.3, which was incompatible.)
civicrm-core allows optional AngularJS modules. (In the past, all
modules were loaded unconditionally, which could result in loading
new/unnecessary code for legacy users. Now, you can opt-out of this
behavior with
basePages=>array().)