CRM-20687: Invert logic and rename variable to remove issue reference

[mickadoo]

Using issue numbers as variables is not very self-explanatory and needs research or prior understanding just to understand the code. See CRM-16084 is enough here to provide a link to the context for the change.

---

The reason for inverting the logic is that I think it's more readable and suitable to this check. To simplify:

$add = TRUE;
foreach ($things as $thing) {
  if (isASpecialThing($thing)) {
    $add = FALSE;
    break;
  }
}

if ($add) {
  addSomething();
}

VS

$dontAdd = FALSE;
foreach ($things as $thing) {
  if (isASpecialThing($thing)) {
    $dontAdd = TRUE;
    break;
  }
}

if (!$dontAdd) {
  addSomething();
}

---

• CRM-20687: Issue numbers used as variables

[omarabuhussein]

oh I see , just noticed that you removed the invert (!) from if (!$crm16084) {

[omarabuhussein]

looks good to me @mickadoo ( approved from my side)

[jitendrapurohit]

Thanks @mickadoo. looks like a good improvement to the code. This can be merged @eileenmcnaughton