CRM-20650 Translate strings #10432
CRM-20650 Translate strings #10432
Conversation
francescbassas
changed the title
| @@ -30,9 +30,9 @@ | |||
| <tr class="columnheader-dark"> | |||
| <th scope="col" rowspan="2">{ts}Members by Type{/ts}</th> | |||
| {if $preMonth} | |||
| <th scope="col" colspan="3">{$premonth} – {ts}(Last Month){/ts}</th> | |||
| <th scope="col" colspan="3">{ts}{$premonth}{/ts} – {ts}(Last Month){/ts}</th> | |||
There was a problem hiding this comment.
You cannot send a variable in "ts", since gettext won't be able to extract the source string.
You might be able to fix upstream by replacing: CRM/Member/Page/DashBoard.php
$this->assign('premonth', date('F', strtotime($preMonth)));
with:
$this->assign('premonth', CRM_Utils_Date::customFormat($preMonth, '%B'));
There was a problem hiding this comment.
Changes applied.
| {/if} | ||
| <th scope="col" colspan="3">{$month}{if $isCurrent}{ts} (MTD){/ts}{/if}</th> | ||
| <th scope="col" colspan="3">{ts}{$month}{/ts}{if $isCurrent}{ts} (MTD){/ts}{/if}</th> |
There was a problem hiding this comment.
@mlutfy I need to do the same with this?
There was a problem hiding this comment.
@francescbassas good catch. Yes, please.
CRM/Member/Page/DashBoard.php
Outdated
| @@ -430,7 +430,7 @@ public function preProcess() { | |||
| $this->assign('totalCount', $totalCount); | |||
| $this->assign('month', date('F', $monthStartTs)); | |||
There was a problem hiding this comment.
line to fix ^ (same as for premonth)
|
@francescbassas Thank you! |
|
Thanks to you @mlutfy and congratulations for your new role as a CiviCRM Core Team 😉 |
https://issues.civicrm.org/jira/browse/CRM-20650