CRM-20624

[yashodha]

• CRM-20624: Expose description field for option values in UI

[seancolsen]

I've chosen to review this in order to help reduce the PR queue.

What this PR actually does

For the record, I just want to explain a bit more about this PR, since the vague description (both here and in Jira) left me to figure it out for myself a bit.

Description

This change improves the process of managing option values for custom fields by allowing users to view and edit descriptions for those option values directly from the "Edit Multiple Choice Options" screen for a given custom field (without having to go to the top-level "Option Groups" page).

Before

1. Administer > Custom Data and Screens > Custom Fields.
2. For a specific custom data set, choose View and Edit Custom Fields.
3. For a specific custom field that has multiple options, choose Edit Multiple Choice Options.
4. Observe a table with different option values.
   
5. Expect to see "Description" column within the table.
6. Observe that no "Description" column exists.
7. Click Edit Option and observe a form for editing the option.
8. Expect to see a "Description" field for editing.
9. Observe that the form has no "Description" field.

After

• Description column added to table display.
  
• Description field added to form.
• Value saves and displays as expected.

Review

(CiviCRM Review Template WORD-1.1)

• (r-explain) PASS
• (r-test) PASS
• (r-code) PASS
• (r-doc) PASS
• (r-maint) PASS
• (r-run) PASS: ran locally, seems to wok fine
  • Worth noting, however, that the standard interface for editing option values at /civicrm/admin/options?reset=1 gives a WYSIWYG editor for option values, whereas the editor provided within this change is text-only. This discrepancy could result in a user creating a rich text description in one place and then becoming confused when they see HTML tags as they edit in another place. But I think that scenario is very unlikely, and shouldn't block this change which is "better in than out" as a whole.
• (r-user) PASS
• (r-tech) PASS

ping @eileenmcnaughton for merging

[eileenmcnaughton]

Thanks @seanmadsen !!!