CRM-20450: Fix invoice math for partial payments. #10222
Conversation
seamuslee001
commented
Apr 24, 2017
•
seamuslee001
commented
- CRM-20450: Fix invoice math for partial payments
|
@KarinG Tested the upgrade and looks good |
|
@seamuslee001 Excellent - thank you for confirming that! |
| @@ -143,6 +143,7 @@ | |||
| <td colspan = "3"></td> | |||
| <td style = "padding-left:20px;text-align:right;"><b><font size = "1">{ts 1=$defaultCurrency}TOTAL %1{/ts}</font></b></td> | |||
| <td style = "padding-left:34px;text-align:right;"><font size = "1">{$amount|crmMoney:$currency}</font></td> | |||
| <td style = "padding-left:34px;"><font size = "1" align = "right"></fonts></td> | |||
There was a problem hiding this comment.
I think the closing tag should be - that is somewhere else in the tpl too
There was a problem hiding this comment.
I think your comment got stripped by GitHub? I've had this line in production since: https://issues.civicrm.org/jira/browse/CRM-19837 - else an unpaid invoice -> runs off the screen [see screenshot in that JIRA issue]; did I miss a tag?
There was a problem hiding this comment.
in this place & 2 others in the tpl (which you probably copied one of) the opening tag is font & the closing tag is fonts. We should merge this first & then fix that
|
I'm ok to merge this - I was really uncomfortable merging anything financial without a test but I took a look & it should be quite trivial to add testing. Since @seamuslee001 is already working on the additional steps & I have got the basis of adding testing I think we should get this merged. Note it is after the rc is cut & I was hell-bent on a really hard-line on any fixes post rc, but the scope of this is very limited and reading the code it is very clear cut that the main line being changed was wrong. (test is https://github.com/civicrm/civicrm-core/compare/master...eileenmcnaughton:inv?expand=1 ) |
|
Test failure unrelated |
|
Thank you! Yeah - pretty sure this is an improvement from: |
