CRM-19813 - Only dispatch through EventDispatcher after booting #10138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After merging civicrm#9949, some screens (like the contact-result list or "View Contact") reported warnings like: ``` Notice: Undefined index: in CRM_Core_BAO_Country::countryLimit() (line 90 of /home/foo/buildkit/build/dmaster/sites/all/modules/civicrm/CRM/Core/BAO/Country.php). Notice: Undefined index: in CRM_Core_BAO_Country::provinceLimit() (line 62 of /home/foo/buildkit/build/dmaster/sites/all/modules/civicrm/CRM/Core/BAO/Country.php). ``` Bisecting the git history revealed that it stemmed from switching `hook_civicrm_entityTypes` to go through EventDispatcher. civicrm@fb1d9ad#diff-8869a8f3c6318eb0580ce2aa04b713bfL1835 This hook is apparently similar to `hook_civicrm_container` in that both fires pre-boot. If we attempt to dispatch it through the container in a pre-boot environment, something initializes incorrectly. This change proposes a general rule: * If you fire a hook before the container or EventDispatcher is available... * Then don't try to use the container or EventDispatcher.
|
looks good - hopefully it will work for my query mod dispatcher - which didn't quite fire before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #9949, some screens (like the contact-result list or "View
Contact") reported warnings like:
Bisecting the git history revealed that it stemmed from switching
hook_civicrm_entityTypesto go through EventDispatcher.fb1d9ad#diff-8869a8f3c6318eb0580ce2aa04b713bfL1835
This hook is apparently similar to
hook_civicrm_containerin that bothfire pre-boot. If we attempt to dispatch it through the container in a
pre-boot environment, something initializes incorrectly.
This change proposes a general rule: