CRM-19741 Add back in fix and add in unit tests to lock in fix #10120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
seamuslee001
commented
Apr 6, 2017
•
seamuslee001
commented
- CRM-19741: Price set and price set value "label" fields are inconsistant to users
|
This fixes regression now @jitendrapurohit @eileenmcnaughton and adds unit tests as well |
|
@jitendrapurohit can you check this - it is the regression you spotted |
CRM/Price/BAO/PriceField.php
Outdated
| @@ -170,7 +176,7 @@ public static function create(&$params) { | |||
| throw new CRM_Core_Exception($e->getMessage()); | |||
| } | |||
| } | |||
| elseif (!empty($optionIds)) { | |||
| elseif (!empty($optionsIds)) { | |||
| $optionsLoad = civicrm_api3('price_field_value', 'get', array('id' => $optionIds['id'])); | |||
There was a problem hiding this comment.
seems an additional typo here - $optionIds - failing the test again?
There was a problem hiding this comment.
Thanks for the ping have fixed it up (minor spelling issues mostly)
|
@jitendrapurohit is this good to merge now? |
jitendrapurohit
approved these changes
Apr 6, 2017
There was a problem hiding this comment.
@eileenmcnaughton yeah, confirmed that it works well. Thanks for the test @seamuslee001
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.