Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-20179 - Fix race condition on manage group page #10117

Merged
merged 1 commit into from
Apr 5, 2017

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Apr 5, 2017

@totten
Copy link
Member

totten commented Apr 5, 2017

Nice:

  • Works in Firefox and Chrome
  • Works in hierarchies with 1, 2, or 3 levels
  • The patch is scoped to a single screen, so it doesn't seem likely to have external side-effects.

I might wait for the test suite to pass -- but tbh, i don't think this affects anything with unit-test-coverage, so in a crunch we could merge anyway.

@totten
Copy link
Member

totten commented Apr 5, 2017

Test failure in CRM_Dedupe_MergerTest::testGetCidRefs cannot be related to this change (templates/CRM/Group/Form/Search.tpl). Triaging separately, but I'll go ahead and merge.

@totten totten merged commit 9923687 into civicrm:4.7.18-rc Apr 5, 2017
@colemanw colemanw deleted the CRM-20179 branch April 5, 2017 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants