Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-20388 - ensure connection errors are properly reported to user. #10115

Merged
merged 1 commit into from
Apr 11, 2017
Merged

CRM-20388 - ensure connection errors are properly reported to user. #10115

merged 1 commit into from
Apr 11, 2017

Conversation

jmcclelland
Copy link
Contributor

@jmcclelland jmcclelland commented Apr 5, 2017 •
edited by civicrm-builder
Loading

@seamuslee001
Copy link
Contributor

Jenkins re test this please

@seamuslee001
Copy link
Contributor

@jmcclelland i am guessing it would be difficult to mock up a unit test to trigger the errors

@eileenmcnaughton
Copy link
Contributor

Really we should throw PaymentProcessorExceptions rather than adding more instances of 'processor specific error handling'. The doPayment method will interpret those & throw 'on behalf' - but eventually we want to take that out of there & have the processors 'throw their own'

@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton eileenmcnaughton merged commit b1af304 into civicrm:master Apr 11, 2017
@eileenmcnaughton
Copy link
Contributor

I would have preferred some changes around the exceptions but ok - let's merge this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmcclelland @seamuslee001 @eileenmcnaughton @civicrm-builder