Crm 20376 - Fix field names on PDF/Print vesion of survey report #10096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jmcclelland can you fix this up - it has gone stale. Might be good to squash the commits too |
|
Please edit out the WIP from the title when fixed & reviewable |
eileenmcnaughton
changed the title
Also, replace deprecated method.
jmcclelland
changed the title
|
Thanks for the review Eileen! I just made the requested changes. |
|
OK - I'm happy to largely defer to you on this report- but one thing still bothering me - $fildCnt Is that $fieldCount ? |
|
Good point - let's clean that up too. |
|
test this please |
1 similar comment
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.