CRM-19715, added upgrade script to delete current_period_opening_bala… #10083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce and opening_balance if they are <> 0 ---------------------------------------- * CRM-19715: Remove Close Accounting Period code https://issues.civicrm.org/jira/browse/CRM-19715
pradpnayak
commented
Mar 30, 2017
| * @param string $rev | ||
| */ | ||
| public function upgrade_4_7_19($rev) { | ||
| $query = "SELECT id FROM civicrm_financial_account WHERE opening_balance <> 0 OR current_period_opening_balance <> 0"; |
There was a problem hiding this comment.
By default this Columns were set to 0. Therefore i checked if this columns have values other than 0 then don't drop column.
|
@eileenmcnaughton @JoeMurray Can you please review this? |
|
looks right to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nce and opening_balance if they are <> 0
https://issues.civicrm.org/jira/browse/CRM-19715