Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-20346. Remove encryptDB.php #10059

Merged

Conversation

xurizaemon
Copy link
Member

🔥🔥🔥

@totten
Copy link
Member

totten commented Mar 28, 2017

die("This script is disabled because it is dangerous. If you need it, please duplicate it elsewhere and provide your own secure workflow. This example file will be removed in the future.");

The future has arrived. No word on flying cars, but we are using Star Trek tablets and talking computers, so it's probably time to delete this.

@totten
Copy link
Member

totten commented Mar 28, 2017

Although, for reference, it's actually hard to delete a dangerous file. IIRC, it doesn't work in the civicrm-joomla upgrade flow (and it doesn't work in some unrecommended Drupal upgrade flows). The safer bet to affirmatively kill a file is to leave behind a placeholder/empty file.

@eileenmcnaughton eileenmcnaughton merged commit 7d6fd06 into civicrm:master Mar 28, 2017
@eileenmcnaughton
Copy link
Contributor

given the 'die' in the file I don't think we need to do the empty file. It is gone!

@eileenmcnaughton eileenmcnaughton deleted the CRM-20346-remove_encryptdb branch March 28, 2017 05:12
@totten
Copy link
Member

totten commented Mar 28, 2017

fwiw, the die() statement was added in 4.7.11 (and probably 4.6.21-ish). So if somebody upgrades from anything older, then they'd still be susceptible to retaining the onerous file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants