CRM-20336: Failed contributions should be set as failed, not left as pending #10041
Conversation
mlutfy
commented
Mar 23, 2017
•
mlutfy
commented
- CRM-20336: Failed iATS contribution should be set to failed, not pending
|
@bgm test failures are real, because you have changed the behaviour & it is checking the old behaviour. On the bright side... you know where to put the tests.... I'm still a little on the fence about this - because it's not uncommon for a payment to fail & money to them come in another way, completing the contribution. But it was endorsed by others on chat & I'm happy to accept that. |
…pending (fix the test).
…pending (more test fixes).
|
@eileenmcnaughton Do these changes seem OK? |
CRM/Contribute/BAO/Contribution.php
Outdated
|
|
||
| civicrm_api3('contribution', 'create', array( | ||
| 'id' => $contributionID, | ||
| 'contribution_status_id' => $failed, |
There was a problem hiding this comment.
If you are calling the api you can save some lines with
'contribution_status_id' => 'Failed',
|
yep - but you might want to just save those lines by letting the api resolve the status |
…pending (cleanup)
|
Setting to merge on pass. Fix & tests look good & there was agreement on dev-financial channel in mattermost regarding this |
|
@eileenmcnaughton this has now passed tests again |
|
@jitendrapurohit I think you are working on a related issue where more aggressively failing transactions may impact on memberships? Might want to make sure that fix is also in 4.7.19 |
|
Yes there is the issue for us fz-r10066 and CRM-18177 |
