Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed CRM-20333: search menu visible even when a user does not has access to any contacts. #10040

Merged
merged 1 commit into from
Apr 4, 2017
Merged

Fixed CRM-20333: search menu visible even when a user does not has access to any contacts. #10040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions CRM/Core/BAO/Navigation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,17 +477,6 @@ public static function getMenuName(&$value, &$skipMenuItems) {
return FALSE;
}

//we need to check core view/edit or supported acls.
if (in_array($menuName, array(
'Search...',
'Contacts',
))) {
if (!CRM_Core_Permission::giveMeAllACLs()) {
$skipMenuItems[] = $navID;
return FALSE;
}
}

$config = CRM_Core_Config::singleton();

$makeLink = FALSE;
Expand Down
2 changes: 0 additions & 2 deletions templates/CRM/common/navigation.js.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
*}// http://civicrm.org/licensing
{capture assign=menuMarkup}{strip}
<ul id="civicrm-menu">
{if call_user_func(array('CRM_Core_Permission','giveMeAllACLs'))}
<li id="crm-qsearch" class="menumain">
<form action="{crmURL p='civicrm/contact/search/advanced' h=0 }" name="search_block" id="id_search_block" method="post">
<div id="quickSearch">
Expand All @@ -50,7 +49,6 @@
<li><label class="crm-quickSearchField"><input type="radio" data-tablename="cc" value="job_title" name="quickSearchField"> {ts}Job Title{/ts}</label></li>
</ul>
</li>
{/if}
{$navigation}
</ul>
{/strip}{/capture}// <script> Generated {$smarty.now|date_format:'%d %b %Y %H:%M:%S'}
Expand Down