Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CRM-20330: composite primary keys #10038

Merged
merged 1 commit into from
Mar 23, 2017

Conversation

jaapjansma
Copy link
Contributor

@jaapjansma jaapjansma commented Mar 23, 2017

Provided a way to generate a table with a composite primary key. Because the generation of dao functionality is changed all the DAO's had to be regenerated.

This is need for the proposed solution for CRM-19934 (performance improvements around acl_contact_cache.


…primary key. Because the generation of dao functionality is changed all the DAO's had to be regenerated.
@eileenmcnaughton
Copy link
Contributor

I took a look at this & am going for a quick merge on it for the following reasons

  1. we just cut the rc so it's a good time to merge
  2. there are no material file changes - it's just DAO checksums & gencode
  3. I feel like this code has really good test coverage (the DAOS) and I don't anticipate any issues outside the test.

I didn't actually review the DAO generation changes in fine detail, due to the fact they aren't actually being called upon here & the 'works when a composite key is added to the xml' is a pretty good test at that point

@eileenmcnaughton eileenmcnaughton merged commit 13d421f into civicrm:master Mar 23, 2017
@eileenmcnaughton
Copy link
Contributor

@jaapjansma does this complete CRM-20330 ?

monishdeb pushed a commit to monishdeb/civicrm-core that referenced this pull request May 2, 2017
Fixed CRM-20330: composite primary keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants