CRM-20299 - CiviMail UI - Cleanup "Location Type" and "Selection Method" #10014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ced options When composing a new mailing, there are advanced options for targetting recipients by location type (`location_type_id`, `email_selection_method`). This ensures that the estimate recipient count updates to match the selection.
If you select a "Location Type" and then deselect it, the field changes to "Automatic". This is the default value (which is acceptable), but the UI flags it as erroneous. The "Selection Method" also defaults to "Automatic". These fields are oddly a bit different (e.g. "Automatic" translates to `location_type_id==null` and `email_selection_method=automatic`), so the fields are a little different, but this revision brings them closer.
|
Tested & this works, scope is narrow - only affecting the mailing form & I don't believe it could affect other areas. |
monishdeb
pushed a commit
to monishdeb/civicrm-core
that referenced
this pull request
May 2, 2017
CRM-20299 - CiviMail UI - Cleanup "Location Type" and "Selection Method"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See detailed descriptions in the two commits.