CRM-20296 - order by even then odd numbers as advertised

[jmcclelland]

I have some mis-givings about this change. Another approach would be to remove the label that says the street numbering will be order by even/add and then put all of this functionality in the Campaign reports. That would keep the core code simpler for functionality that may only be wanted in Campaign mode (which includes the survey components that are typically used to generate these reports in the first place).

---

• CRM-20296: Order by street number (odd/even) does not order by odd/even street numbers

[xurizaemon]

Simpler sounds better. It might be worth making this optional at point of producing the report; while it's convenient to have it, we shouldn't presume all locations (eg rural) will be simplest to handle sorted odd/even. (Maybe it's already optional the, idk?)

[eileenmcnaughton]

@jmcclelland I'm going to close this because it's stale & has a conflict. If you want to pick it up again we can look at it - there is another report related one that I need to look at soon that might mess with it though so not too soon...

[jmcclelland]

Hi Eileen - which is the other report related issue? In the US, we are gearing up for an election cycle, which means more groups are doing the door-knocking reports that need the even/odd ordering so I will probably be keeping this commit in our production code. But I can certainly wait and re-submit later on once you make your changes.

Also, I could try to figure out how to stick it in the campaign reports only.

[eileenmcnaughton]

@jmcclelland looking at it the other one doesn't apply that well.

You can override orderBy on the campaign reports - if you need to call a shared function it could be in the parent class although it might be nice to try a trait

[jmcclelland]

This was fixed in a better way via: #12422