Merge pull request #13173 from christianwach/issue-557

Prevent viewport jump when toggling help on "Administer CiviCRM" screen
civicrm · Dec 2, 2018 · bbdb4ee · bbdb4ee
2 parents 3cfaf3d + 3f8fccc
commit bbdb4ee
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/CRM/Core/ShowHideBlocks.php b/CRM/Core/ShowHideBlocks.php
@@ -178,8 +178,8 @@ public static function linkHtml($name, $href, $text, $js) {
    * @return array
    */
   public static function links(&$form, $prefix, $showLinkText, $hideLinkText, $assign = TRUE) {
-    $showCode = "cj('#id_{$prefix}').show(); cj('#id_{$prefix}_show').hide();";
-    $hideCode = "cj('#id_{$prefix}').hide(); cj('#id_{$prefix}_show').show(); return false;";
+    $showCode = "if(event.preventDefault) event.preventDefault(); else event.returnValue = false; cj('#id_{$prefix}').show(); cj('#id_{$prefix}_show').hide();";
+    $hideCode = "if(event.preventDefault) event.preventDefault(); else event.returnValue = false; cj('#id_{$prefix}').hide(); cj('#id_{$prefix}_show').show();";
 
     self::setIcons();
     $values = array();