Skip to content

Commit

Permalink
dev/mail#20 : Preview screen don't open until recipients list is buil…
Browse files Browse the repository at this point in the history
…t on mail compose screen
  • Loading branch information
monishdeb committed Aug 6, 2018
1 parent 1eaa530 commit a76869e
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions ang/crmMailing/services.js
Original file line number Diff line number Diff line change
Expand Up @@ -262,8 +262,15 @@
// @param mailing Object (per APIv3)
// @return Promise an object with "subject", "body_text", "body_html"
preview: function preview(mailing) {
return this.getPreviewContent(qApi, mailing)
},

// @param backend
// @param mailing Object (per APIv3)
// @return preview content
getPreviewContent: function getPreviewContent(backend, mailing) {
if (CRM.crmMailing.workflowEnabled && !CRM.checkPerm('create mailings') && !CRM.checkPerm('access CiviMail')) {
return qApi('Mailing', 'preview', {id: mailing.id}).then(function(result) {
return backend('Mailing', 'preview', {id: mailing.id}).then(function(result) {
return result.values;
});
}
Expand All @@ -278,7 +285,7 @@
delete params.scheduled_date;
delete params.recipients; // the content was merged in
params._skip_evil_bao_auto_recipients_ = 1; // skip recipient rebuild on mail preview
return qApi('Mailing', 'create', params).then(function(result) {
return backend('Mailing', 'create', params).then(function(result) {
mailing.modified_date = result.values[result.id].modified_date;
// changes rolled back, so we don't care about updating mailing
return result.values[result.id]['api.Mailing.preview'].values;
Expand Down Expand Up @@ -451,7 +458,7 @@
};
var result = null;
var p = crmMailingMgr
.preview(mailing)
.getPreviewContent(CRM.api3, mailing)
.then(function (content) {
var options = CRM.utils.adjustDialogDefaults({
autoOpen: false,
Expand Down

0 comments on commit a76869e

Please sign in to comment.