Skip to content

Commit

Permalink
dev/core#1141 remove sql_calc_rows
Browse files Browse the repository at this point in the history
It's gone for mysql8 & I just checked & in this case the count is never used so it can just go
  • Loading branch information
eileenmcnaughton committed Jul 24, 2019
1 parent 3d41bd9 commit 9d1ef4d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CRM/Report/Form/Contribute/History.php
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,7 @@ public function buildRows($sql, &$rows) {
$addWhere .= " AND {$this->_aliases['civicrm_contact']}.id IN ( SELECT DISTINCT cont.id FROM civicrm_contact cont, civicrm_contribution contri WHERE cont.id = contri.contact_id AND {$receive_date} = {$this->_referenceYear['this_year']} AND contri.is_test = 0 ) ";
}
$this->limit();
$getContacts = "SELECT SQL_CALC_FOUND_ROWS {$this->_aliases['civicrm_contact']}.id as cid, SUM({$this->_aliases['civicrm_contribution']}.total_amount) as civicrm_contribution_total_amount_sum {$this->_from} {$this->_where} {$addWhere} GROUP BY {$this->_aliases['civicrm_contact']}.id {$this->_having} {$this->_limit}";
$getContacts = "SELECT {$this->_aliases['civicrm_contact']}.id as cid, SUM({$this->_aliases['civicrm_contribution']}.total_amount) as civicrm_contribution_total_amount_sum {$this->_from} {$this->_where} {$addWhere} GROUP BY {$this->_aliases['civicrm_contact']}.id {$this->_having} {$this->_limit}";

$dao = CRM_Core_DAO::executeQuery($getContacts);

Expand Down

0 comments on commit 9d1ef4d

Please sign in to comment.