make case type required for change case type activity instead of a pr…

…eprocess check that doesn't work
civicrm · Mar 16, 2020 · 9611f1f · 9611f1f
1 parent ffdf4f9
commit 9611f1f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 12 deletions.
diff --git a/CRM/Case/Form/Activity.php b/CRM/Case/Form/Activity.php
@@ -145,17 +145,6 @@ public function preProcess() {
       );
     }
     if (!$this->_activityId) {
-      $caseTypes = CRM_Case_PseudoConstant::caseType();
-
-      if (empty($caseTypes) && ($this->_activityTypeName == 'Change Case Type') && !$this->_caseId) {
-        $url = CRM_Utils_System::url('civicrm/contact/view/case',
-          "reset=1&action=view&cid={$this->_currentlyViewedContactId}&id={$caseIds}&show=1"
-        );
-        $session = CRM_Core_Session::singleton();
-        $session->pushUserContext($url);
-        CRM_Core_Error::statusBounce(ts("You do not have any active Case Types"));
-      }
-
       // check if activity count is within the limit
       $xmlProcessor = new CRM_Case_XMLProcessor_Process();
       foreach ($this->_caseId as $casePos => $caseId) {

diff --git a/CRM/Case/Form/Activity/ChangeCaseType.php b/CRM/Case/Form/Activity/ChangeCaseType.php
@@ -68,7 +68,7 @@ public static function buildQuickForm(&$form) {
       $form->_caseType[$form->_caseTypeId] = CRM_Core_DAO::getFieldValue('CRM_Case_DAO_CaseType', $form->_caseTypeId, 'title');
     }
 
-    $form->addField('case_type_id', ['context' => 'create', 'entity' => 'Case']);
+    $form->addField('case_type_id', ['context' => 'create', 'entity' => 'Case'], TRUE);
 
     // timeline
     $form->addYesNo('is_reset_timeline', ts('Reset Case Timeline?'), NULL, TRUE);

diff --git a/tests/phpunit/CRM/Core/FormTest.php b/tests/phpunit/CRM/Core/FormTest.php
@@ -57,6 +57,14 @@ function(CRM_Core_Form $form) {
           $form->_action = CRM_Core_Action::ADD;
         },
       ],
+      // This one is a bit flawed but the only point of this test is to catch
+      // simple stuff. This will catch e.g. "undefined index" and similar.
+      'Find Contacts' => [
+        'CRM_Contact_Form_Search_Basic',
+        function(CRM_Core_Form $form) {
+          $form->_action = CRM_Core_Action::BASIC;
+        },
+      ],
     ];
   }