Fix (sometimes serious) performance problem on submitting profiles fo…

…r specified contacts.

->_id is set when the contact id is known - e.g in edit, in contactlayouteditor profile
blocks. However, current logic still retrieves duplicates and then... does nothing
with them if ->_id is set. By moving the if up higher we can save the server from
doing unnecesary queries. Note that if you submit a tag profile with no other fields in it
the query is server-destroyingly bad with this

CRM/Profile/Form.php

@@ -219,9 +219,7 @@ protected static function handleDuplicateChecking(&$errors, $fields, $form) {
         CRM_Core_Session::setStatus(ts('Note: this contact may be a duplicate of an existing record.'), ts('Possible Duplicate Detected'), 'alert');
       }
       elseif ($form->_isUpdateDupe == 1) {
-        if (!$form->_id) {
-          $form->_id = $ids[0];
-        }
+        $form->_id = $ids[0];
       }
       else {
         if ($form->_context == 'dialog') {
@@ -1003,6 +1001,8 @@ public static function formRule($fields, $files, $form) {
 
     // hack we use a -1 in options to indicate that its registration
     if ($form->_id) {
+      // @todo - wonder if it ever occurred to someone that if they didn't document this param
+      // it might not be crystal clear why we have it....
       $form->_isUpdateDupe = 1;
     }
 
@@ -1022,7 +1022,9 @@ public static function formRule($fields, $files, $form) {
         $fields['phone-Primary'] = $fields['phone-Primary-1'];
       }
 
-      self::handleDuplicateChecking($errors, $fields, $form);
+      if (!$form->_id) {
+        self::handleDuplicateChecking($errors, $fields, $form);
+      }
     }
 
     foreach ($fields as $key => $value) {