Merge pull request #13461 from christianwach/lab-666

Fix trailing ampersands when empty array passed as query param
civicrm · Jan 22, 2019 · 6b9ac69 · 6b9ac69
2 parents fe7f28f + ffa6291
commit 6b9ac69
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/CRM/Utils/System/WordPress.php b/CRM/Utils/System/WordPress.php
@@ -257,11 +257,6 @@ public function url(
 
     $queryParts = array();
 
-    // CRM_Core_Payment::getReturnSuccessUrl() passes $query as an array
-    if (isset($query) && is_array($query)) {
-      $query = implode($separator, $query);
-    }
-
     if (
       // not using clean URLs
       !$config->cleanURL
@@ -283,7 +278,7 @@ public function url(
       if ($wpPageParam) {
         $queryParts[] = $wpPageParam;
       }
-      if (isset($query)) {
+      if (!empty($query)) {
         $queryParts[] = $query;
       }