CRM-19153 Bug fixes

---------------------------------------- * CRM-19153: Future pledge start date causes improper future pledge payment dates https://issues.civicrm.org/jira/browse/CRM-19153
civicrm · Sep 1, 2016 · 627bdaf · 627bdaf
1 parent 7c8cd80
commit 627bdaf
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/CRM/Contribute/BAO/Contribution/Utils.php b/CRM/Contribute/BAO/Contribution/Utils.php
@@ -138,7 +138,7 @@ public static function processConfirm(
         $paymentParams['source'] = $paymentParams['contribution_source'];
       }
 
-      if ($form->_params['is_recur'] && $contribution->contribution_recur_id) {
+      if (CRM_Utils_Array::value('is_recur', $form->_params) && $contribution->contribution_recur_id) {
         $paymentParams['contributionRecurID'] = $contribution->contribution_recur_id;
       }
       if (isset($paymentParams['contribution_source'])) {

diff --git a/CRM/Contribute/Form/Contribution/Confirm.php b/CRM/Contribute/Form/Contribution/Confirm.php
@@ -1854,14 +1854,18 @@ public static function submit($params) {
     $form->_fields['billing_first_name'] = 1;
     $form->_fields['billing_last_name'] = 1;
     // CRM-18854 - Set form values to allow pledge to be created for api test.
-    if (CRM_Utils_Array::value('pledge_block_id', $params)) {
+    if (CRM_Utils_Array::value('pledge_block_id', $params) && !CRM_Utils_Array::value('pledge_id', $params)) {
       $form->_values['pledge_block_id'] = $params['pledge_block_id'];
       $pledgeBlock = CRM_Pledge_BAO_PledgeBlock::getPledgeBlock($params['id']);
       $form->_values['max_reminders'] = $pledgeBlock['max_reminders'];
       $form->_values['initial_reminder_day'] = $pledgeBlock['initial_reminder_day'];
       $form->_values['additional_reminder_day'] = $pledgeBlock['additional_reminder_day'];
       $form->_values['is_email_receipt'] = FALSE;
     }
+    if (CRM_Utils_Array::value('pledge_id', $params) && CRM_Utils_Array::value('pledge_block_id', $params)) {
+      $form->_values['pledge_id'] = $params['pledge_id'];
+      $form->_values['pledge_block_id'] = $params['pledge_block_id'];
+    }
     $priceSetID = $form->_params['priceSetId'] = $paramsProcessedForForm['price_set_id'];
     $priceFields = CRM_Price_BAO_PriceSet::getSetDetail($priceSetID);
     $priceSetFields = reset($priceFields);

diff --git a/CRM/Pledge/BAO/PledgeBlock.php b/CRM/Pledge/BAO/PledgeBlock.php
@@ -202,7 +202,6 @@ public static function buildPledgeBlock($form) {
         'scheduled_date',
         'scheduled_amount',
         'currency',
-        'pledge_start_date',
       );
       CRM_Core_DAO::commonRetrieveAll('CRM_Pledge_DAO_PledgePayment', 'pledge_id',
         $form->_values['pledge_id'], $allPayments, $returnProperties