CRM-21148 revert back to odd handling when NULL passed to getFromTo, …

…deprecate

CRM/Report/Form.php

@@ -2056,6 +2056,8 @@ public function dateClause(
   /**
    * Get values for from and to for date ranges.
    *
+   * @deprecated
+   *
    * @param bool $relative
    * @param string $from
    * @param string $to
@@ -2064,7 +2066,13 @@ public function dateClause(
    *
    * @return array
    */
-  public function getFromTo($relative, $from, $to, $fromTime = NULL, $toTime = '235959') {
+  public function getFromTo($relative, $from, $to, $fromTime = NULL, $toTime = NULL) {
+    if (empty($toTime)) {
+      // odd legacy behaviour to treat NULL as 'end of the day'
+      // recommend updating reports to call CRM_Utils_Date::getFromTo
+      //directly (default on the function is the actual default there).
+      $toTime = '235959';
+    }
     return CRM_Utils_Date::getFromTo($relative, $from, $to, $fromTime, $toTime);
   }