Merge pull request #14300 from colemanw/Fix

[REF] Fix pointless use of CRM_Utils_Array::value in Campaign BAO
civicrm · May 23, 2019 · 5dc0161 · 5dc0161
2 parents 2b6c13e + cb4d135
commit 5dc0161
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/CRM/Campaign/BAO/Campaign.php b/CRM/Campaign/BAO/Campaign.php
@@ -49,18 +49,18 @@ public static function create(&$params) {
       return NULL;
     }
 
-    if (!(CRM_Utils_Array::value('id', $params))) {
+    if (empty($params['id'])) {
 
-      if (!(CRM_Utils_Array::value('created_id', $params))) {
+      if (empty($params['created_id'])) {
         $session = CRM_Core_Session::singleton();
         $params['created_id'] = $session->get('userID');
       }
 
-      if (!(CRM_Utils_Array::value('created_date', $params))) {
+      if (empty($params['created_date'])) {
         $params['created_date'] = date('YmdHis');
       }
 
-      if (!(CRM_Utils_Array::value('name', $params))) {
+      if (empty($params['name'])) {
         $params['name'] = CRM_Utils_String::titleToVar($params['title'], 64);
       }