Fix "no such field" failure in SmartGroup upgrade

Calling api get with no return fields specified is always risky during upgrades because upgrades can add/drop columns.
civicrm · Mar 4, 2020 · 4de4307 · 4de4307
1 parent 4efbd5d
commit 4de4307
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/CRM/Upgrade/Incremental/SmartGroups.php b/CRM/Upgrade/Incremental/SmartGroups.php
@@ -232,12 +232,11 @@ public function renameFields($pairs) {
    * @return mixed
    */
   protected function getSearchesWithField($field) {
-    $savedSearches = civicrm_api3('SavedSearch', 'get', [
+    return civicrm_api3('SavedSearch', 'get', [
       'options' => ['limit' => 0],
       'form_values' => ['LIKE' => "%{$field}%"],
+      'return' => ['id', 'form_values'],
     ])['values'];
-    return $savedSearches;
-
   }
 
   /**