CRM-20926 - CRM_Core_Menu - Parse XML element <ids_arguments>

civicrm · Aug 4, 2017 · 4535c1f · 4535c1f
1 parent 5bfe764
commit 4535c1f
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 0 deletions.
diff --git a/CRM/Core/Menu.php b/CRM/Core/Menu.php
@@ -132,6 +132,19 @@ public static function readXML($xml, &$menu) {
       $path = (string ) $item->path;
       $menu[$path] = array();
       unset($item->path);
+
+      if ($item->ids_arguments) {
+        $ids = array();
+        foreach (array('json', 'html', 'exception') as $type) {
+          $ids[$type] = array();
+          foreach ($item->ids_arguments->{$type} as $value) {
+            $ids[$type][] = (string) $value;
+          }
+        }
+        $menu[$path]['ids_arguments'] = $ids;
+        unset($item->ids_arguments);
+      }
+
       foreach ($item as $key => $value) {
         $key = (string ) $key;
         $value = (string ) $value;

diff --git a/tests/phpunit/CRM/Core/MenuTest.php b/tests/phpunit/CRM/Core/MenuTest.php
@@ -30,6 +30,31 @@ public function testReadXML() {
     $this->assertEquals('Customize Data and Screens', $menu['civicrm/foo/bar']['adminGroup']);
     $this->assertEquals('admin/small/foo.png', $menu['civicrm/foo/bar']['icon']);
     $this->assertEquals('10', $menu['civicrm/foo/bar']['weight']);
+    $this->assertTrue(!isset($menu['civicrm/foo/bar']['ids_arguments']));
+  }
+
+  public function testReadXML_IDS() {
+    $xmlString = '<?xml version="1.0" encoding="iso-8859-1" ?>
+    <menu>
+      <item>
+         <path>civicrm/foo/bar</path>
+         <title>Foo Bar</title>
+         <ids_arguments>
+          <json>alpha</json>
+          <json>beta</json>
+          <html>gamma</html>
+        </ids_arguments>
+      </item>
+    </menu>
+    ';
+    $xml = simplexml_load_string($xmlString);
+    $menu = array();
+    CRM_Core_Menu::readXML($xml, $menu);
+    $this->assertTrue(isset($menu['civicrm/foo/bar']));
+    $this->assertEquals('Foo Bar', $menu['civicrm/foo/bar']['title']);
+    $this->assertEquals(array('alpha', 'beta'), $menu['civicrm/foo/bar']['ids_arguments']['json']);
+    $this->assertEquals(array('gamma'), $menu['civicrm/foo/bar']['ids_arguments']['html']);
+    $this->assertEquals(array(), $menu['civicrm/foo/bar']['ids_arguments']['exception']);
   }
 
   /**