CRM-20600 - Angular deps - Move from *.js to *.php

If third-parties are allowed to alter the HTML content, then they may
introduce new dependencies.  This means that they'll need to delcare those
dependencies.

This commit actually moves the declarations for any in-house modules to PHP.

ang/crmAttachment.ang.php

@@ -11,4 +11,5 @@
   'settings' => array(
     'token' => \CRM_Core_Page_AJAX_Attachment::createToken(),
   ),
+  'requires' => array('angularFileUpload'),
 );

ang/crmAttachment.js

@@ -1,7 +1,7 @@
 /// crmFile: Manage file attachments
 (function (angular, $, _) {
 
-  angular.module('crmAttachment', ['angularFileUpload']);
+  angular.crmDepends('crmAttachment');
 
   // crmAttachment manages the list of files which are attached to a given entity
   angular.module('crmAttachment').factory('CrmAttachments', function (crmApi, crmStatus, FileUploader, $q) {

ang/crmAutosave.ang.php

@@ -6,4 +6,5 @@
 return array(
   'ext' => 'civicrm',
   'js' => array('ang/crmAutosave.js'),
+  'requires' => array('crmUtil'),
 );

ang/crmAutosave.js

@@ -1,7 +1,7 @@
 /// crmAutosave
 (function(angular, $, _) {
 
-  angular.module('crmAutosave', ['crmUtil']);
+  angular.crmDepends('crmAutosave');
 
   // usage:
   //   var autosave = new CrmAutosaveCtrl({

ang/crmCaseType.ang.php

@@ -16,4 +16,5 @@
   'js' => array('ang/crmCaseType.js'),
   'css' => array('ang/crmCaseType.css'),
   'partials' => array('ang/crmCaseType'),
+  'requires' => array('ngRoute', 'ui.utils', 'crmUi', 'unsavedChanges', 'crmUtil'),
 );

ang/crmCaseType.js

@@ -1,6 +1,6 @@
 (function(angular, $, _) {
 
-  var crmCaseType = angular.module('crmCaseType', ['ngRoute', 'ui.utils', 'crmUi', 'unsavedChanges', 'crmUtil']);
+  var crmCaseType = angular.crmDepends('crmCaseType');
 
   // Note: This template will be passed to cloneDeep(), so don't put any funny stuff in here!
   var newCaseTypeTemplate = {

ang/crmCxn.ang.php

@@ -8,4 +8,5 @@
   'js' => array('ang/crmCxn.js', 'ang/crmCxn/*.js'),
   'css' => array('ang/crmCxn.css'),
   'partials' => array('ang/crmCxn'),
+  'requires' => array('crmUtil', 'ngRoute', 'ngSanitize', 'ui.utils', 'crmUi', 'dialogService'),
 );

ang/crmCxn.js

@@ -1,8 +1,6 @@
 (function (angular, $, _) {
 
-  angular.module('crmCxn', [
-    'crmUtil', 'ngRoute', 'ngSanitize', 'ui.utils', 'crmUi', 'dialogService'
-  ]);
+  angular.crmDepends('crmCxn');
 
   angular.module('crmCxn').config([
     '$routeProvider',

ang/crmD3.ang.php

@@ -12,4 +12,5 @@
     'ang/crmD3.js',
     'bower_components/d3/d3.min.js',
   ),
+  'requires' => array(),
 );

ang/crmD3.js

@@ -1,4 +1,3 @@
 (function (angular, $, _) {
-  // thin stub for declaring dependencies
-  angular.module('crmD3', []);
+  angular.crmDepends('crmD3');
 })(angular, CRM.$, CRM._);

ang/crmExample.ang.php

@@ -7,4 +7,5 @@
   'ext' => 'civicrm',
   'js' => array('ang/crmExample.js'),
   'partials' => array('ang/crmExample'),
+  'requires' => array('crmUtil', 'ngRoute', 'ui.utils', 'crmUi'),
 );

ang/crmExample.js

@@ -1,8 +1,6 @@
 (function(angular, $, _) {
 
-  angular.module('crmExample', [
-    'crmUtil', 'ngRoute', 'ui.utils', 'crmUi'
-  ]);
+  angular.crmDepends('crmExample');
 
   angular.module('crmExample').config([
     '$routeProvider',

ang/crmMailing.ang.php

@@ -14,4 +14,5 @@
   ),
   'css' => array('ang/crmMailing.css'),
   'partials' => array('ang/crmMailing'),
+  'requires' => array('crmUtil', 'crmAttachment', 'crmAutosave', 'ngRoute', 'ui.utils', 'crmUi', 'dialogService'),
 );

ang/crmMailing.js

@@ -1,8 +1,6 @@
 (function (angular, $, _) {
 
-  angular.module('crmMailing', [
-    'crmUtil', 'crmAttachment', 'crmAutosave', 'ngRoute', 'ui.utils', 'crmUi', 'dialogService'
-  ]);
+  angular.crmDepends('crmMailing');
 
   angular.module('crmMailing').config([
     '$routeProvider',

ang/crmMailingAB.ang.php

@@ -15,4 +15,5 @@
   ),
   'css' => array('ang/crmMailingAB.css'),
   'partials' => array('ang/crmMailingAB'),
+  'requires' => array('ngRoute', 'ui.utils', 'crmUi', 'crmAttachment', 'crmMailing', 'crmD3'),
 );

ang/crmMailingAB.js

@@ -1,6 +1,6 @@
 (function(angular, $, _) {
 
-  angular.module('crmMailingAB', ['ngRoute', 'ui.utils', 'crmUi', 'crmAttachment', 'crmMailing', 'crmD3']);
+  angular.crmDepends('crmMailingAB');
   angular.module('crmMailingAB').config([
     '$routeProvider',
     function($routeProvider) {

ang/crmStatusPage.ang.php

@@ -11,4 +11,5 @@
   'css' => array('ang/crmStatusPage.css'),
   'partials' => array('ang/crmStatusPage'),
   'settings' => array(),
+  'requires' => array('crmUi', 'crmUtil', 'ngRoute'),
 );

ang/crmStatusPage.js

@@ -1,8 +1,5 @@
 (function(angular, $, _) {
-  // Declare a list of dependencies.
-  angular.module('statuspage', [
-    'crmUi', 'crmUtil', 'ngRoute'
-  ]);
+  angular.crmDepends('statuspage');
 
   // router
   angular.module('statuspage').config( function($routeProvider) {

ang/crmUi.ang.php

@@ -7,4 +7,5 @@
   'ext' => 'civicrm',
   'js' => array('ang/crmUi.js'),
   'partials' => array('ang/crmUi'),
+  'requires' => array(),
 );

ang/crmUi.js

@@ -5,7 +5,7 @@
     pageTitle = 'CiviCRM',
     documentTitle = 'CiviCRM';
 
-  angular.module('crmUi', [])
+  angular.crmDepends('crmUi')
 
     // example <div crm-ui-accordion crm-title="ts('My Title')" crm-collapsed="true">...content...</div>
     // WISHLIST: crmCollapsed should support two-way/continuous binding

ang/crmUtil.ang.php

@@ -6,4 +6,5 @@
 return array(
   'ext' => 'civicrm',
   'js' => array('ang/crmUtil.js'),
+  'requires' => array(),
 );

ang/crmUtil.js

@@ -1,6 +1,6 @@
 /// crmUi: Sundry UI helpers
 (function (angular, $, _) {
-  angular.module('crmUtil', []);
+  angular.crmDepends('crmUtil');
 
   // Angular implementation of CRM.api3
   // @link http://wiki.civicrm.org/confluence/display/CRMDOC/AJAX+Interface#AJAXInterface-CRM.api3