CRM_Core_Resources - Allow container to swap the implementation

civicrm · Oct 18, 2018 · 223ba02 · 223ba02
1 parent df466fe
commit 223ba02
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 8 deletions.
diff --git a/CRM/Core/Resources.php b/CRM/Core/Resources.php
@@ -115,13 +115,7 @@ static public function singleton(CRM_Core_Resources $instance = NULL) {
       self::$_singleton = $instance;
     }
     if (self::$_singleton === NULL) {
-      $sys = CRM_Extension_System::singleton();
-      $cache = Civi::cache('js_strings');
-      self::$_singleton = new CRM_Core_Resources(
-        $sys->getMapper(),
-        $cache,
-        CRM_Core_Config::isUpgradeMode() ? NULL : 'resCacheCode'
-      );
+      self::$_singleton = Civi::service('resources');
     }
     return self::$_singleton;
   }

diff --git a/Civi/Core/Container.php b/Civi/Core/Container.php
@@ -201,7 +201,6 @@ public function createContainer() {
 
     // Expose legacy singletons as services in the container.
     $singletons = array(
-      'resources' => 'CRM_Core_Resources',
       'httpClient' => 'CRM_Utils_HttpClient',
       'cache.default' => 'CRM_Utils_Cache',
       'i18n' => 'CRM_Core_I18n',
@@ -216,6 +215,11 @@ public function createContainer() {
     }
     $container->setAlias('cache.short', 'cache.default');
 
+    $container->setDefinition('resources', new Definition(
+      'CRM_Core_Resources',
+      [new Reference('service_container')]
+    ))->setFactory(array(new Reference(self::SELF), 'createResources'));
+
     $container->setDefinition('prevnext', new Definition(
       'CRM_Core_PrevNextCache_Interface',
       [new Reference('service_container')]
@@ -411,6 +415,19 @@ public function createApiKernel($dispatcher, $magicFunctionProvider) {
     return $kernel;
   }
 
+  /**
+   * @param ContainerInterface $container
+   * @return \CRM_Core_Resources
+   */
+  public static function createResources($container) {
+    $sys = \CRM_Extension_System::singleton();
+    return new \CRM_Core_Resources(
+      $sys->getMapper(),
+      $container->get('cache.js_strings'),
+      \CRM_Core_Config::isUpgradeMode() ? NULL : 'resCacheCode'
+    );
+  }
+
   /**
    * @param ContainerInterface $container
    * @return \CRM_Core_PrevNextCache_Interface