Merge pull request #14560 from seamuslee001/null_array_profile

Remove unncessary $_nullArray usage when calling createProfileContact function
civicrm · Jun 17, 2019 · 1861244 · 1861244
2 parents 5414c31 + 7b4b0b6
commit 1861244
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/CRM/Core/BAO/UFMatch.php b/CRM/Core/BAO/UFMatch.php
@@ -296,7 +296,7 @@ public static function &synchronizeUFMatch(&$user, $userKey, $uniqId, $uf, $stat
           }
         }
 
-        $contactId = CRM_Contact_BAO_Contact::createProfileContact($params, CRM_Core_DAO::$_nullArray);
+        $contactId = CRM_Contact_BAO_Contact::createProfileContact($params);
         $ufmatch->contact_id = $contactId;
         $ufmatch->uf_name = $uniqId;
       }

diff --git a/CRM/Friend/BAO/Friend.php b/CRM/Friend/BAO/Friend.php
@@ -64,7 +64,7 @@ public function __construct() {
    * @return int
    */
   public static function add(&$params) {
-    return CRM_Contact_BAO_Contact::createProfileContact($params, CRM_Core_DAO::$_nullArray);
+    return CRM_Contact_BAO_Contact::createProfileContact($params);
   }
 
   /**

diff --git a/tests/phpunit/CRM/Contribute/BAO/ContributionTest.php b/tests/phpunit/CRM/Contribute/BAO/ContributionTest.php
@@ -245,7 +245,8 @@ public function testCreateAndGetHonorContact() {
     );
     $softParam = array('soft_credit_type_id' => 1);
 
-    $honoreeContactId = CRM_Contact_BAO_Contact::createProfileContact($params, CRM_Core_DAO::$_nullArray,
+    $null = [];
+    $honoreeContactId = CRM_Contact_BAO_Contact::createProfileContact($params, $null,
       NULL, NULL, $honoreeProfileId
     );