Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wal2json pg16 package available #153

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Wal2json pg16 package available #153

merged 1 commit into from
Nov 23, 2023

Conversation

naisila
Copy link
Member

@naisila naisila commented Nov 15, 2023 •
edited
Loading

Wal2json PG16 package is now available.

Sister PR citusdata/citus#7361

@naisila naisila requested a review from hanefi November 16, 2023 11:20
hanefi
hanefi approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@hanefi hanefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

In first glance I did not like the absence of a version for this package. However, this is not really significant as we install it from debian repositories and the version is not directly linked to pgdg versions.

@naisila
Copy link
Member Author

naisila commented Nov 17, 2023

Thanks for reviewing @hanefi
I will merge when I create the sister PR in citus repo to include wal2json tests found in cdc suite with PG16.

@naisila naisila mentioned this pull request Nov 23, 2023
Merged
@naisila naisila marked this pull request as ready for review November 23, 2023 11:51
@naisila naisila merged commit 19b671f into master Nov 23, 2023
15 checks passed
naisila added a commit to citusdata/citus that referenced this pull request Nov 24, 2023
@naisila
Run wal2json cdc test for pg16 as well (#7361)
c019acc 
pg16 wal2json package is now available, adding the tests back. Basically
reverting
f253bb3

Sister PR citusdata/the-process#153
@hanefi hanefi deleted the naisila/add_wal2json_16 branch December 13, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanefi hanefi hanefi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naisila @hanefi