Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi-node ubuntu changes #1055

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

francisjodi
Copy link

No description provided.

@francisjodi francisjodi marked this pull request as ready for review June 27, 2022 15:22
@francisjodi francisjodi reopened this Jun 27, 2022
@francisjodi francisjodi reopened this Jun 27, 2022
Copy link
Member

@jonels-msft jonels-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Is there a way to make the command for starting the db server do the right thing automatically, rather than having the user grep through process list?


**4. Start database servers, create Citus extension**

::

# start the db server
sudo service postgresql restart
or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain more about why we present alternatives here? When would someone choose to restart postgresql vs postgresql@14-main ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea is to ensure that someone does not start the server on another Postgres server. I had this issue where it started on a 9.5 server instead of 14. Someone would use postgres@14-main to ensure connection to postgres14, another person can use restart Postgres if they are sure their server is already on 14. Which would be the note about ps - ef.
We could eliminate the option entirely and allow users to only use one.

# and make it start automatically when computer does
sudo update-rc.d postgresql enable

.. note::
Ensure you are starting the right postges version. You can check this by running ``ps -ef | grep Postgres``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the ps -ef ... be woven into the restart commands above? Ideally we could have the script itself detect the right service to restart.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that would be the best thing to do to ensure users are starting the right thing automatically.

Copy link
Member

@jonels-msft jonels-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @francisjodi, are you interested in submitting a change to automate the script's restart logic, by means of ps -ef ... or otherwise?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants