-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove warnings on some builds #7680
Conversation
@microsoft-github-policy-service agree company="Sbertech" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7680 +/- ##
===========================================
- Coverage 89.69% 49.04% -40.65%
===========================================
Files 283 282 -1
Lines 60510 59501 -1009
Branches 7541 7313 -228
===========================================
- Hits 54276 29185 -25091
- Misses 4079 27699 +23620
- Partials 2155 2617 +462 |
… function Werror=return-type
Head branch was pushed to by a user without write access
7a8fc3a
to
29f7d02
Compare
@hanefi I have squashed commits to better readability |
Co-authored-by: Pavel Seleznev <PNSeleznev@sberbank.ru>
Co-authored-by: Pavel Seleznev <PNSeleznev@sberbank.ru> (cherry picked from commit fe6d198)
We have a product where the warning Werror=return-type is enabled and is treated as an error for the entire build process. So our build process stops. Of course, we can do tricks in the build script, but I guess this commit will be useful because it removes one excluded warning.