Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings on some builds #7680

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

SeleznevPavel
Copy link
Contributor

We have a product where the warning Werror=return-type is enabled and is treated as an error for the entire build process. So our build process stops. Of course, we can do tricks in the build script, but I guess this commit will be useful because it removes one excluded warning.

@SeleznevPavel
Copy link
Contributor Author

SeleznevPavel commented Aug 30, 2024

@microsoft-github-policy-service agree company="Sbertech"
@microsoft-github-policy-service agree

@SeleznevPavel
Copy link
Contributor Author

@hanefi @thanodnl

This pull request stopped my work on the main product - I can't modify the Citus sources in the project I am working on currently. Do you think it's possible to merge this pull request into the main branch?

Also, I didn't know how the review process is organized in Citus project.

@hanefi hanefi enabled auto-merge (squash) December 2, 2024 11:59
@hanefi hanefi changed the title Added ability to build with warning - control reaches end of non-void function Werror=return-type" Remove warnings on some builds Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.04%. Comparing base (c52f360) to head (29f7d02).
Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (c52f360) and HEAD (29f7d02). Click for more details.

HEAD has 151 uploads less than BASE
Flag BASE (c52f360) HEAD (29f7d02)
14_regress_check-pytest 2 0
_upgrade 30 1
15_regress_check-follower-cluster 2 0
14_regress_check-columnar-isolation 2 0
14_regress_check-follower-cluster 2 0
16_regress_check-pytest 2 0
15_regress_check-pytest 2 0
15_regress_check-query-generator 2 0
14_16_upgrade 2 0
15_regress_check-enterprise-isolation-logicalrep-3 2 0
16_regress_check-query-generator 2 0
16_regress_check-follower-cluster 2 0
15_regress_check-enterprise-isolation-logicalrep-2 2 0
15_regress_check-columnar-isolation 2 0
14_regress_check-enterprise-isolation-logicalrep-3 2 0
16_regress_check-columnar-isolation 2 0
16_regress_check-enterprise-isolation-logicalrep-3 2 0
15_regress_check-columnar 2 0
14_regress_check-split 2 0
14_regress_check-columnar 2 0
15_regress_check-split 2 0
14_regress_check-enterprise-failure 2 0
15_regress_check-multi-mx 2 0
15_regress_check-enterprise 2 0
15_regress_check-enterprise-isolation-logicalrep-1 2 0
14_regress_check-enterprise-isolation-logicalrep-1 2 0
16_regress_check-enterprise-isolation 2 0
16_regress_check-enterprise-isolation-logicalrep-1 2 0
14_regress_check-enterprise 2 0
16_cdc_installcheck 2 0
15_cdc_installcheck 2 0
14_regress_check-query-generator 2 0
16_regress_check-enterprise-failure 2 0
14_regress_check-enterprise-isolation-logicalrep-2 2 0
14_regress_check-operations 2 0
16_regress_check-failure 2 0
14_regress_check-multi-mx 2 0
16_regress_check-multi-mx 2 0
14_regress_check-failure 2 0
15_regress_check-failure 2 0
15_regress_check-enterprise-isolation 2 0
15_regress_check-vanilla 2 0
16_regress_check-enterprise-isolation-logicalrep-2 2 0
14_15_upgrade 2 0
16_regress_check-columnar 2 0
15_regress_check-isolation 2 0
16_regress_check-isolation 2 0
14_regress_check-isolation 2 0
14_regress_check-multi 2 0
15_regress_check-multi 2 0
16_regress_check-multi 2 0
15_regress_check-multi-1 1 0
14_regress_check-multi-1 1 0
16_regress_check-multi-1 2 0
15_regress_check-operations 2 0
16_regress_check-operations 2 0
16_regress_check-vanilla 2 0
15_16_upgrade 2 0
16_regress_check-enterprise 2 0
15_regress_check-enterprise-failure 2 0
14_regress_check-enterprise-isolation 2 0
14_regress_check-vanilla 2 0
16_regress_check-split 2 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7680       +/-   ##
===========================================
- Coverage   89.69%   49.04%   -40.65%     
===========================================
  Files         283      282        -1     
  Lines       60510    59501     -1009     
  Branches     7541     7313      -228     
===========================================
- Hits        54276    29185    -25091     
- Misses       4079    27699    +23620     
- Partials     2155     2617      +462     

auto-merge was automatically disabled December 3, 2024 09:16

Head branch was pushed to by a user without write access

@SeleznevPavel
Copy link
Contributor Author

@hanefi I have squashed commits to better readability

@hanefi hanefi merged commit fe6d198 into citusdata:main Dec 3, 2024
120 of 122 checks passed
winter-loo pushed a commit to winter-loo/citus that referenced this pull request Jan 7, 2025
Co-authored-by: Pavel Seleznev <PNSeleznev@sberbank.ru>
naisila pushed a commit that referenced this pull request Jan 13, 2025
Co-authored-by: Pavel Seleznev <PNSeleznev@sberbank.ru>
(cherry picked from commit fe6d198)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants