Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support MERGE command for single_shard_distributed Target #7643

Merged
merged 14 commits into from
Jul 16, 2024
Merged

Support MERGE command for single_shard_distributed Target #7643

merged 14 commits into from
Jul 16, 2024

Conversation

paragikjain
Copy link
Contributor

@paragikjain paragikjain commented Jul 4, 2024 •
edited
Loading

This PR has following changes :

  1. Enable MERGE command for single_shard_distributed targets.

@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.

Project coverage is 55.83%. Comparing base (accb7d0) to head (346422e).

❗ There is a different number of reports uploaded between BASE (accb7d0) and HEAD (346422e). Click for more details.

HEAD has 64 uploads less than BASE
Flag BASE (accb7d0) HEAD (346422e)
16_regress_check-query-generator 1 0
14_regress_check-query-generator 1 0
16_regress_check-enterprise-isolation-logicalrep-2 1 0
14_regress_check-columnar 1 0
15_regress_check-columnar 1 0
16_regress_check-enterprise-failure 1 0
14_regress_check-enterprise 1 0
15_cdc_installcheck 1 0
14_regress_check-multi-mx 1 0
14_regress_check-split 1 0
14_regress_check-enterprise-isolation-logicalrep-2 1 0
14_regress_check-enterprise-failure 1 0
16_regress_check-columnar 1 0
16_regress_check-enterprise-isolation-logicalrep-3 1 0
15_regress_check-enterprise-failure 1 0
15_regress_check-vanilla 1 0
16_regress_check-split 1 0
16_regress_check-enterprise-isolation 1 0
14_regress_check-enterprise-isolation 1 0
16_regress_check-enterprise 1 0
15_regress_check-isolation 1 0
14_regress_check-isolation 1 0
16_regress_check-isolation 1 0
_upgrade 19 1
16_regress_check-multi 1 0
15_regress_check-multi 1 0
14_regress_check-multi 1 0
15_regress_check-operations 1 0
15_regress_check-enterprise-isolation 1 0
16_regress_check-vanilla 1 0
15_regress_check-enterprise-isolation-logicalrep-1 1 0
16_regress_check-multi-1 1 0
16_regress_check-multi-mx 1 0
15_regress_check-enterprise 1 0
15_regress_check-multi-mx 1 0
14_regress_check-failure 1 0
16_regress_check-enterprise-isolation-logicalrep-1 1 0
16_cdc_installcheck 1 0
14_regress_check-enterprise-isolation-logicalrep-1 1 0
14_regress_check-vanilla 1 0
15_regress_check-failure 1 0
16_regress_check-failure 1 0
16_regress_check-operations 1 0
14_regress_check-operations 1 0
15_regress_check-multi-1 1 0
14_regress_check-pytest 1 0
14_regress_check-multi-1 1 0
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #7643       +/-   ##
===========================================
- Coverage   89.69%   55.83%   -33.86%     
===========================================
  Files         283      283               
  Lines       60507    60483       -24     
  Branches     7540     7530       -10     
===========================================
- Hits        54271    33773    -20498     
- Misses       4080    23784    +19704     
- Partials     2156     2926      +770

@paragikjain paragikjain changed the title [Fix] : Push Merge Command to worker when all tables are single sharded and colocated [Fix Command Merge] Let's pull data to coordinator if re-partitioning in target not supported. Jul 4, 2024
rajeshkt78
rajeshkt78 reviewed Jul 10, 2024
View reviewed changes
Copy link
Contributor

@rajeshkt78 rajeshkt78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dummy comment

@hanefi hanefi mentioned this pull request Jul 12, 2024
Merged
@hanefi
Copy link
Member

hanefi commented Jul 12, 2024

Can you rebase, or merge changes in main to this branch? We fixed some issues in our test infra, and a rebase/merge would help you here.

@paragikjain paragikjain changed the title [Fix Command Merge] Let's pull data to coordinator if re-partitioning in target not supported. [Fix Command Merge] Let's pull data to coordinator for single shard distributed target. Jul 13, 2024
@paragikjain paragikjain changed the title [Fix Command Merge] Let's pull data to coordinator for single shard distributed target. Support MERGE command for single_shard_distributed Target and a bugfix Jul 14, 2024
@paragikjain paragikjain changed the title Support MERGE command for single_shard_distributed Target and a bugfix Support MERGE command for single_shard_distributed Target Jul 16, 2024
tejeswarm
tejeswarm approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@tejeswarm tejeswarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tejeswarm tejeswarm merged commit 3c467e6 into citusdata:main Jul 16, 2024
150 of 151 checks passed
paragikjain added a commit to paragikjain/citus that referenced this pull request Jul 16, 2024
@paragikjain
Support MERGE command for single_shard_distributed Target (citusdata#…
43ef2d7 
…7643)

This PR has following changes :
1. Enable MERGE command for single_shard_distributed targets.

(cherry picked from commit 3c467e6)
hanefi pushed a commit that referenced this pull request Jul 17, 2024
@paragikjain @hanefi
Support MERGE command for single_shard_distributed Target (#7643)
a5ef010 
This PR has following changes :
1. Enable MERGE command for single_shard_distributed targets.

(cherry picked from commit 3c467e6)
hanefi pushed a commit that referenced this pull request Jul 17, 2024
@paragikjain @hanefi
Support MERGE command for single_shard_distributed Target (#7643)
6349f2d 
This PR has following changes :
1. Enable MERGE command for single_shard_distributed targets.

(cherry picked from commit 3c467e6)
winter-loo pushed a commit to winter-loo/citus that referenced this pull request Jan 7, 2025
@paragikjain @winter-loo
Support MERGE command for single_shard_distributed Target (citusdata#…
3c56311 
…7643)

This PR has following changes :
1. Enable MERGE command for single_shard_distributed targets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onurctirtir onurctirtir onurctirtir left review comments

@rajeshkt78 rajeshkt78 rajeshkt78 left review comments

@tejeswarm tejeswarm tejeswarm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paragikjain @hanefi @onurctirtir @tejeswarm @rajeshkt78