Support rails 7.1 #208
Merged
Support rails 7.1 #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `table_name` method was defined in `Arel::Nodes::Table` and `Arel::Nodes::TableAlias` to get the table name, but `Arel::Nodes::Table#table_name` was removed rails/rails#46864. Therefore, it is no longer possible to simply call `#table_name` to get `table_name`, so a `TableNode.table_name` has been added to get table_name from node.
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
+ Coverage 82.68% 82.85% +0.16%
==========================================
Files 14 15 +1
Lines 722 729 +7
==========================================
+ Hits 597 604 +7
Misses 125 125
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
serprex
approved these changes
Sep 13, 2023
gurkanindibay
approved these changes
Sep 14, 2023
|
thanks @alpaca-tc for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today rails7.1.0.beta1 has been released, I have added support for activerecord-multitenant.
The changes are as follows.
Arel::Nodes::Table#table_namesinceArel::Nodes::Table#namehas been removed