Improved testing coverage and TranscribeAudio endpoint refactor

[citomcclure]

Overall

Testing Coverage

Increased testing coverage from 35% to 55%:

TranscribeAudio Refactor

Created wrapper classes for S3 and Transcribe and moved non-business logic out of activity class. This made the class testable and provided much better readability.

Implementation

Unit tests for the following classes:

• ModelConverter
• NoteDateTimeConverter
• TranscriptionUtils
• GetNotesActivity
• ClientProviders (ddb, s3, transcribe)
• TranscribeAudioActivity

New methods (and moved logic):

• S3Wrapper
  • putAudioInS3()
  • getAudioLocation()
  • getTranscriptionJobResult()
• TranscribeWrapper
  • startTranscriptionJob()
  • pollTranscriptionJob()
• TranscriptionUtils
  • getSampleRate()

Other

• Remaining tests to write include S3Wrapper and TranscribeWrapper, which would put the testing coverage up to ~65%
• Made several attempts at creating unit tests for ClientProvider classes. Was only able to test for null region. Likely would require a refactoring of those classes and how they are used in Dependency Injection by having each client provider class depend on the client builder and then providing those through DI. Then those builders could be mocked and the Region value could be intercepted using an ArgumentCaptor
• For my own future reference, static methods make mocking a bit trickier and should not be used all the time for utility classes
• Deleted CollectionUtils class - was not being used
• Deleted methods from NullUtils class - were note being used
• Deleted S3Utils class - moved bucket names over to S3Wrapper