Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(minidump): correct sourcegraph link #3036

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(minidump): correct sourcegraph link #3036

wants to merge 1 commit into from

Conversation

Mathu-lmn
Copy link
Contributor

I couldn't test this since the symbols doesn't seemed to load on a custom build (https://discord.com/channels/192358910387159041/1227992483724525609/1282757127714111540).
But I believe the frame contains a first instance of "fivem/master/fivem/code/...." so I switched to rfind to get the last occurence of fivem/ instead of the first one.

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

Fixes #2735

@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prikolium-cfx prikolium-cfx Awaiting requested review from prikolium-cfx

Assignees
No one assigned
Labels
invalid Requires changes before it's considered valid and can be (re)triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fivem crash windows sourcegraph link invalid
1 participant
@Mathu-lmn