-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip CodeQL Workflow for Dependabot Branches on push Events #73
Merged
mcdonnnj
merged 2 commits into
develop
from
improvement/skip_codeql_on_push_for_dependabot_branches
Apr 15, 2021
Merged
Skip CodeQL Workflow for Dependabot Branches on push Events #73
mcdonnnj
merged 2 commits into
develop
from
improvement/skip_codeql_on_push_for_dependabot_branches
Apr 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should resolve the following error: Error: Workflows triggered by Dependabot on the "push" event run with read-only access. Uploading Code Scanning results requires write access. To use Code Scanning with Dependabot, please ensure you are using the "pull_request" event for this workflow and avoid triggering on the "push" event for Dependabot branches. See https://docs.github.com/en/code-security/secure-coding/configuring-code-scanning#scanning-on-push for more information on how to configure these events.
mcdonnnj
added
bug
This issue or pull request addresses broken functionality
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
labels
Apr 7, 2021
hillaryj
approved these changes
Apr 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
jsf9k
approved these changes
Apr 8, 2021
dav3r
approved these changes
Apr 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍
mcdonnnj
added
the
blocked
This issue or pull request is awaiting the outcome of another issue or pull request
label
Apr 8, 2021
felddy
approved these changes
Apr 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BOOSH! 🎆
mcdonnnj
deleted the
improvement/skip_codeql_on_push_for_dependabot_branches
branch
April 15, 2021 17:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked
This issue or pull request is awaiting the outcome of another issue or pull request
bug
This issue or pull request addresses broken functionality
improvement
This issue or pull request will add or improve functionality, maintainability, or ease of use
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR adjusts the CodeQL GitHub Actions workflow to skip
push
events from branches automatically generated by Dependabot. This will resolve #72.💭 Motivation and context
This resolves the problem described in the following error observed In cisagov/con-pca-api#224:
🧪 Testing
Automated tests pass. After implementing this change in cisagov/con-pca-api#224 I observed that the
CodeQL / Analyze (python) (push)
check was skipped as expected.✅ Checklist