Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the version of the ansible-lint pre-commit hook #197

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Update the version of the ansible-lint pre-commit hook #197

merged 1 commit into from
Nov 20, 2024
+1 −1

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Nov 13, 2024 •
edited
Loading

🗣 Description

This pull request updates the version of the ansible-lint pre-commit hook.

💭 Motivation and context

Version 24.10.0 is the first version that supports Fedora 41 as a valid platform. We want to add support for Fedora 41 in cisagov/skeleton-ansible-role#207.

🧪 Testing

All automated tests pass. These changes were also tested as part of cisagov/skeleton-ansible-role#207.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k
Update the version of the ansible-lint pre-commit hook
b9f798d 
Version 24.10.0 is the first version that supports Fedora 41 as a
valid platform.
@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release labels Nov 13, 2024
@jsf9k jsf9k marked this pull request as ready for review November 13, 2024 15:38
@jsf9k jsf9k requested a review from a team November 13, 2024 15:38
@jsf9k jsf9k mentioned this pull request Nov 13, 2024
Merged
8 tasks
@jsf9k jsf9k added this pull request to the merge queue Nov 20, 2024
Merged via the queue into develop with commit a794735 Nov 20, 2024
4 checks passed
@jsf9k jsf9k deleted the improvement/upgrade-ansible-lint-pre-commit-hook-version branch November 20, 2024 18:02
timscharfenort8

This comment was marked as spam.

Sign in to view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timscharfenort8 timscharfenort8 timscharfenort8 left review comments

@dav3r dav3r dav3r approved these changes

@lwersiy lwersiy lwersiy approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@jsf9k jsf9k

@mcdonnnj mcdonnnj

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Next Kraken
Status: Done
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jsf9k @dav3r @lwersiy @timscharfenort8 @mcdonnnj