Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use preferred capitalization for Docker and Docker Hub #65

Merged
merged 6 commits into from
Jul 23, 2021
Merged

Use preferred capitalization for Docker and Docker Hub #65

merged 6 commits into from
Jul 23, 2021

Conversation

dav3r
Copy link
Member

@dav3r dav3r commented Jul 15, 2021 •
edited
Loading

🗣 Description

This PR updates various files to use the preferred capitalization for Docker and Docker Hub.

💭 Motivation and context

We are trying to be better about capitalization across the board.

🧪 Testing

All automated tests pass.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@dav3r dav3r added the documentation This issue or pull request improves or adds to documentation label Jul 15, 2021
@dav3r dav3r self-assigned this Jul 15, 2021
@dav3r dav3r requested review from felddy, jsf9k and mcdonnnj as code owners July 15, 2021 16:32
@jsf9k jsf9k added the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Jul 15, 2021
@dav3r dav3r changed the title Use preferred capitalization for Docker Hub Use preferred capitalization for Docker and Docker Hub Jul 15, 2021
@dav3r dav3r mentioned this pull request Jul 15, 2021
Merged
1 task
mcdonnnj
mcdonnnj approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! Thank you for getting these language changes in here.

@mcdonnnj mcdonnnj merged commit c6aa7f0 into develop Jul 23, 2021
@mcdonnnj mcdonnnj deleted the dav3r-patch-1 branch July 23, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@dav3r dav3r

@mcdonnnj mcdonnnj

Labels
blocked This issue or pull request is awaiting the outcome of another issue or pull request documentation This issue or pull request improves or adds to documentation
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dav3r @jsf9k @mcdonnnj