Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the Pin for actions/github-script to v4 #63

Merged
merged 2 commits into from
Jul 22, 2021
Merged

Update the Pin for actions/github-script to v4 #63

merged 2 commits into from
Jul 22, 2021

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This PR updates the actions/github-script from v3 to v4.

💭 Motivation and context

This covers PRs such as #58 by updating to pin to the current major version.

🧪 Testing

I confirmed that the GitHub Actions run had the data pulled by the step using actions/github-script.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@mcdonnnj mcdonnnj added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use upstream update This issue or pull request pulls in upstream updates labels Jun 22, 2021
@mcdonnnj mcdonnnj requested review from dav3r, felddy and jsf9k as code owners June 22, 2021 14:53
@mcdonnnj mcdonnnj self-assigned this Jun 22, 2021
dav3r
dav3r approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

jsf9k
jsf9k approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Onward and upward!

@mcdonnnj mcdonnnj added the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Jun 23, 2021
@mcdonnnj mcdonnnj mentioned this pull request Jul 13, 2021
Closed
@mcdonnnj mcdonnnj merged commit d10c669 into develop Jul 22, 2021
@mcdonnnj mcdonnnj deleted the update/bump_github-script_to_v4 branch July 22, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@mcdonnnj mcdonnnj

Labels
blocked This issue or pull request is awaiting the outcome of another issue or pull request improvement This issue or pull request will add or improve functionality, maintainability, or ease of use upstream update This issue or pull request pulls in upstream updates
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdonnnj @jsf9k @dav3r