Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the README to reference the latest version of the Docker container #62

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Update the README to reference the latest version of the Docker container #62

merged 1 commit into from
Jun 16, 2021

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jun 15, 2021 •
edited
Loading

🗣 Description

This pull request:

  • Updates README.md to reference the latest version of the Docker container
  • Corrects git commit comments to use the imperative mood

💭 Motivation and context

The README.md change was discussed among @cisagov/team-ois here.

🧪 Testing

I ran bump_version.sh with these changes locally and verified that it behaved as expected.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k
Update the README to reference the latest version of the Docker conta…
68948bb 
…iner

This change was discussed among @cisagov/team-ois here:
cisagov/gatherer#60 (review)

Also correct git comments to use the imperative mood.
@jsf9k jsf9k added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Jun 15, 2021
@jsf9k jsf9k self-assigned this Jun 15, 2021
@jsf9k jsf9k marked this pull request as ready for review June 15, 2021 14:04
@jsf9k jsf9k requested review from dav3r, felddy and mcdonnnj as code owners June 15, 2021 14:04
dav3r
dav3r approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! 👍

mcdonnnj
mcdonnnj approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent addition! :shipit:

@jsf9k jsf9k merged commit ce74596 into develop Jun 16, 2021
@jsf9k jsf9k deleted the improvement/use-latest-version-number-in-readme branch June 16, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsf9k @dav3r @mcdonnnj